We're updating the issue view to help you get more done. 

NextRow() in FMPXMLResultReader incompletely overrides parent

Description

Running an import using FMPXML dies silently. There's a bug and a feature that masks the bug

The feature is in DataReaderManager.php in get() where

if (!($o_node_list = @$this->opo_handle_xpath->query($ps_spec))) {
happens. The @ suppresses errors so the process dies silently when confronted with errors

The bug is that FMPXMLResultReader.php overrides its parent's NextRow() method but looks like it does so based on an earlier version which results in opo_handle_xml and opo_handle_xpath not getting set. opo_handle_xpath being null causes the above line in DataReaderManager.php to fail silently.

I just commented out the overriding code and the importer started working.

Environment

CentOS 6.5

Activity

Show:
Dale MacDonald
October 15, 2015, 7:55 AM

Oops I meant

The feature is in BaseXMLDataReader.php in get() where

User known
October 15, 2015, 8:13 AM

Yeah, I see. There's some old code stuck in there. I just pushed fixes for this to the master-fix branch on GitHub. Can you let me know if it works for you?

Dale MacDonald
October 15, 2015, 8:49 AM

Yep, that fixed it. Now back to debugging my mapping file Thanks!

User known
October 15, 2015, 8:54 AM

That's the only thing worse than Filemaker I guess!

Fixed

Assignee

User known

Reporter

Dale MacDonald

Labels

Components

Affects versions

Priority

Major
Configure