Uploaded image for project: 'Providence'
  1. PROV-1391

NextRow() in FMPXMLResultReader incompletely overrides parent

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects versions: 1.5.1
    • Fix versions: None
    • Components: Data importer
    • Labels:
    • Environment:
      CentOS 6.5

      Description

      Running an import using FMPXML dies silently. There's a bug and a feature that masks the bug

      The feature is in DataReaderManager.php in get() where

      if (!($o_node_list = @$this->opo_handle_xpath->query($ps_spec))) {
      happens. The @ suppresses errors so the process dies silently when confronted with errors

      The bug is that FMPXMLResultReader.php overrides its parent's NextRow() method but looks like it does so based on an earlier version which results in opo_handle_xml and opo_handle_xpath not getting set. opo_handle_xpath being null causes the above line in DataReaderManager.php to fail silently.

      I just commented out the overriding code and the importer started working.

        Attachments

          Activity

            People

            • Assignee:
              Former user (Inactive)
              Reporter:
              Dale MacDonald
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: