We're updating the issue view to help you get more done. 

Duplicated code

Description

All core media plugins in app\lib\core\Plugins\Media* directly work with the configuration file external_applications.conf, duplicating the logic implemented in app\helpers\mediaPluginHelpers.php. It makes more sense for me to follow the pattern used in PDF render plugins app\lib\core\Plugins\PDFRenderer*, with calls to caGetExternalApplicationPath($plugin_name) in constructors, avoiding potential pitfalls of duplicating the same logic. For example, caGetExternalApplicationPath is where automatic plugin detection can be straightforwardly added.

Environment

Windows 7, Bitnami WAMP

Activity

Show:
oper251
December 2, 2017, 11:25 AM

Also, should constructors in app\lib\core\Plugins\Media* explicitly call parent constructors like in app\lib\core\Plugins\PDFRenderer* ?

Seth
May 22, 2020, 5:12 PM

Replaced by

Assignee

Seth

Reporter

oper251

Labels

None

Components

Fix versions

Affects versions

Priority

Minor
Configure